librelist archives

« back to archive

Thank goodness for firebug ...

Thank goodness for firebug ...

From:
Hank Marquardt
Date:
2009-12-29 @ 12:19
So Chad finally submits his piece ... I listen to it, write my
comments and ....

"Waiting to listen to 1 submission" with the submit greyed out ....

I listened to the whole piece, twice even .. and I've listened to
mine, the only other submission, so I did what all us "Geeks First,
Guitarists Second" would do ... I looked at the source; which lead to
app.js, which lead to the firebug console and
"enable_after_playing(-1);"

I submitted my comment then.   I do think the process should be easier
though for mere mortals, unless you're only targeting folks attending
JSConf 2010 ... they'll get it pretty easily.

Anyway, I'm on Linux, running FF 3.5.2 in case it's a browser compat
bug ... though I have to say seeing the if statement (if
(waiting_submissions < 0)) struck me as an odd indexing choice for
clearing the submit button -- I didn't do the debugging for you, I'm
just assuming that's correct as others have submitted comments before
me just fine.

Re: [fretwar] Thank goodness for firebug ...

From:
Zed A. Shaw
Date:
2009-12-29 @ 17:07
On Tue, Dec 29, 2009 at 06:19:29AM -0600, Hank Marquardt wrote:
> So Chad finally submits his piece ... I listen to it, write my
> comments and ....
> 
> "Waiting to listen to 1 submission" with the submit greyed out ....
> 
> I listened to the whole piece, twice even .. and I've listened to

Ok, so it's bugging out at some point, Chad had the same problem.

> Anyway, I'm on Linux, running FF 3.5.2 in case it's a browser compat
> bug ... though I have to say seeing the if statement (if
> (waiting_submissions < 0)) struck me as an odd indexing choice for
> clearing the submit button -- I didn't do the debugging for you, I'm
> just assuming that's correct as others have submitted comments before
> me just fine.

That indexing is because flowplayer is weird with what it calls a "clip"
and how the events fire off.  All sorts of strange off by one errors and
crap, and I couldn't figure out how to get that event and use it to get
the actual clip being played.

Anyway, I'll debug it tonight, and just back out that change right now.

Damn! And I thought I caught Chad in his tracks for not listening. :-)

-- 
Zed A. Shaw
http://zedshaw.com/

Re: [fretwar] Thank goodness for firebug ...

From:
Chad Woolley
Date:
2009-12-29 @ 18:21
On Tue, Dec 29, 2009 at 10:07 AM, Zed A. Shaw <zedshaw@zedshaw.com> wrote:
> Damn! And I thought I caught Chad in his tracks for not listening. :-)

I'm hurt that you think I would rate without listening.  I actually
listened to Hank's submission multiple times.

I think you should display the amount of time listened, to keep
everyone honest (and shame the dishonest ones).

Re: [fretwar] Thank goodness for firebug ...

From:
Zed A. Shaw
Date:
2009-12-29 @ 18:24
On Tue, Dec 29, 2009 at 11:21:07AM -0700, Chad Woolley wrote:
> On Tue, Dec 29, 2009 at 10:07 AM, Zed A. Shaw <zedshaw@zedshaw.com> wrote:
> > Damn! And I thought I caught Chad in his tracks for not listening. :-)
> 
> I'm hurt that you think I would rate without listening.  I actually
> listened to Hank's submission multiple times.
> 
> I think you should display the amount of time listened, to keep
> everyone honest (and shame the dishonest ones).

Ha, yeah I know you do.  Actually, I was thinking of a funny little >>
icon next to their comment if they don't listen to the whole thing.
Problem is with multiple submissions that gets difficult.

For now it's just the honor system.

-- 
Zed A. Shaw
http://zedshaw.com/