librelist archives

« back to archive

[PATCH] reorder cc args for proper linking with libdl

[PATCH] reorder cc args for proper linking with libdl

From:
Leonid Evdokimov
Date:
2014-07-22 @ 09:58
That's required on Ubuntu 14.04 with gcc 4.8.2-19ubuntu1.

I don't know if `ldd -r` is universal test for undefined dynamic
symbols, but it's good enough for me :)

-- 
WBRBW, Leonid Evdokimov
xmpp:leon@darkk.net.ru && http://darkk.net.ru && tel:+79816800702

Re: [libnodelay] [PATCH] reorder cc args for proper linking with libdl

From:
Eric Wong
Date:
2014-07-22 @ 17:08
Leonid Evdokimov <leon@darkk.net.ru> wrote:
> That's required on Ubuntu 14.04 with gcc 4.8.2-19ubuntu1.
> 
> I don't know if `ldd -r` is universal test for undefined dynamic
> symbols, but it's good enough for me :)

Thanks, applied and pushed, I completely forgot this project.
Any other patches queued up?  I should release before I forget again.

I also pushed out some minor changes while I was at it and will release
soon.

Eric Wong (2):
      remove update-freshmeat
      add "or later" clause to LGPLv3

Leonid Evdokimov (1):
      reorder cc args for proper linking with libdl

> diff --git Makefile Makefile
> index 4e44277..bc57764 100644
> --- Makefile
> +++ Makefile

Btw, I needed to edit the patch before applying (or use "patch -p0")
Normal git patches have a directory prefix in them, so I edited
them to allow "git am" to apply it:

	diff --git a/Makefile b/Makefile
	index 4e44277..bc57764 100644
	--- a/Makefile
	+++ b/Makefile

I'm just wondering if you used some weird tool or option to get that
weird patch.  No big deal, but it might confuse others since git
tools prefer a one-level directory prefix.

Thanks again!

Re: [libnodelay] [PATCH] reorder cc args for proper linking with libdl

From:
Leonid Evdokimov
Date:
2014-07-22 @ 18:37
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 07/22/2014 09:08 PM, Eric Wong wrote:
> Thanks, applied and pushed, I completely forgot this project.

I used it as a template for another LD_PREALOAD library :)

> Any other patches queued up?

nope.

> I'm just wondering if you used some weird tool or option to get
> that weird patch.  No big deal, but it might confuse others since
> git tools prefer a one-level directory prefix.

That's `diff.noprefix = true` in my .gitconfig.
Thank you for pointing this out, most of my contributions are
pull-requests nowadays and diff is usually better without prefix, so I
completely missed that.

Leonid.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJTzq96AAoJEOHyqYB/UPqy8BcP/298dDYhdAQluOsACdkgwFc/
nGLxPb0arTUvJsqS21K98fEulgO8lrhuscalzA9YWID0YF/ycvVzU6hcMLTIua9Y
oEJDzQDhfyvzv76B09xcwYC+uAYEWxCQXvKR4427WBHAZm+K0Dzd5GzSr8XTy/zR
GX4XJTQKJP64YDs4KxH6uRH4Rzg65z9r8cmdK4tDkTx4pyKIDtM/rFnAB17m5kNi
k3AWoGearrc4Fqa5G//75laACBmo8JQCeFfTSaynW5IB72hGusNNoCGvFJ0WgEgf
VQryrKn0iZXAMlMRpw32oBQ7EUZGx1o2RedvpEbKVTm4/MbGXGcOtKDKuwcL5Hbg
9cwk5gUOL0SuQzEEeuNT4NjFCDgC9R6S1zyd4R7pkqk4ggn1htb0KVOkKopYc4f0
f360lw7oc0VJCOW5k1fK5HNNVh9buVWI+5JUkZHXU6Tz66v26z1LF948MDP48V71
j6Kx+4z3VdJtGLEQraCtu+Ojwe2GcMuxHddfqVvdQYSChahTNJMSm+rR27as8ZaT
IEybA2p4q0G42l4wUm22B3bNwqaYxH8Ebky6X21SWvzDvz3NS7nyL9jrLz1knlRX
s/Dd7gXgA7jGTESFuAy0wn8HSM4FoDQlp2xDbuvs/iYSM29cCzf3WfMXUPACAHhP
Vf75zPAYNWwoU6pU1Hkv
=OfK5
-----END PGP SIGNATURE-----