librelist archives

« back to archive

pull request: issue #13 (2) "Testing for section/partial bug"

pull request: issue #13 (2) "Testing for section/partial bug"

From:
Chris Jerdonek
Date:
2011-12-01 @ 16:07
Here is the second pull request for issue #13, which corrects a test
expectation (and so causes it to fail with respect to the current
code):

https://github.com/rhettg/pystache/commit/dedcfbd08bdadf106b3f8162ec7cd3ff221c815b

I'm okay with proceeding with this one.

Also, I believe the change to the test case can be fixed with a
one-line code change.  I think that fix should go along with the test
case (in a commit separate from the pull request) -- so that all tests
are working after both commits.

--Chris

Re: [pystache] pull request: issue #13 (2) "Testing for section/partial bug"

From:
Tim Kersten
Date:
2011-12-01 @ 23:15
On Thu, Dec 1, 2011 at 16:07, Chris Jerdonek <chris.jerdonek@gmail.com> wrote:
> Here is the second pull request for issue #13, which corrects a test
> expectation (and so causes it to fail with respect to the current
> code):
>
> 
https://github.com/rhettg/pystache/commit/dedcfbd08bdadf106b3f8162ec7cd3ff221c815b
>
> I'm okay with proceeding with this one.
>
> Also, I believe the change to the test case can be fixed with a
> one-line code change.  I think that fix should go along with the test
> case (in a commit separate from the pull request) -- so that all tests
> are working after both commits.
>
> --Chris
>

Sounds good.

Tim ^,^

Re: [pystache] pull request: issue #13 (2) "Testing for section/partial bug"

From:
Chris Jerdonek
Date:
2011-12-02 @ 02:43
On Thu, Dec 1, 2011 at 3:15 PM, Tim Kersten <tim@io41.com> wrote:
> On Thu, Dec 1, 2011 at 16:07, Chris Jerdonek <chris.jerdonek@gmail.com> wrote:
>> Here is the second pull request for issue #13, which corrects a test
>> expectation (and so causes it to fail with respect to the current
>> code):
>>
>> 
https://github.com/rhettg/pystache/commit/dedcfbd08bdadf106b3f8162ec7cd3ff221c815b
>>
>> I'm okay with proceeding with this one.
>>
>> Also, I believe the change to the test case can be fixed with a
>> one-line code change.  I think that fix should go along with the test
>> case (in a commit separate from the pull request) -- so that all tests
>> are working after both commits.
>>
>> --Chris
>>
>
> Sounds good.

Thanks.  I committed the request and associated changes to the
development branch.

--Chris