librelist archives

« back to archive

Pause implementaiton

Pause implementaiton

From:
Eoin Coffey
Date:
2013-04-29 @ 19:48
As a group, how in love are we with the current pause implementation?

I really like it, but it's kind of a pain to write tests against (which is
what I'm trying to do right now...).

The 1-x strategy is "wasteful" (the process is still sitting in a loop,
sleeping for N seconds and then immediately going back to sleep if still
paused), and not that responsive (may have to wait N seconds before it will
actually start pulling work again), but it was easy to test :)

Thoughts?

Re: [resque] Pause implementaiton

From:
Steve Klabnik
Date:
2013-04-29 @ 19:56
I am not in love with any bit of implementation that is not tested under 
test/resque. In fact, most of it is old and kinda bad.


Please submit all the refactorings. ;) <3
—
Sent from Mailbox for iPhone

On Mon, Apr 29, 2013 at 1:49 PM, Eoin Coffey <ecoffey@gmail.com> wrote:

> As a group, how in love are we with the current pause implementation?
> I really like it, but it's kind of a pain to write tests against (which is
> what I'm trying to do right now...).
> The 1-x strategy is "wasteful" (the process is still sitting in a loop,
> sleeping for N seconds and then immediately going back to sleep if still
> paused), and not that responsive (may have to wait N seconds before it will
> actually start pulling work again), but it was easy to test :)
> Thoughts?