librelist archives

« back to archive

Latest code for wheel support in pip

Latest code for wheel support in pip

From:
Paul Moore
Date:
2012-10-11 @ 19:15
A couple of questions (because I've got myself confused :-))

1. Where should I go to get the latest version of wheel support for
pip? Is dholth's fork still the "latest and greatest" at this time?
2. Is it worth me waiting for Marcus' branch to land somewhere? Or
indeed, is it available already?

The reason is that I'd like to look at the code in pip/index.py which
finds wheels, to add a check that the wheel is valid for the current
Python API/platform (because it's an issue for me at the moment, so
I'd like to get it fixed). And I want to make sure I'm working on code
that's not out of date.

Thanks,
Paul.

Re: [wheel] Latest code for wheel support in pip

From:
Marcus Smith
Date:
2012-10-12 @ 04:37
I'll do whatever everyone thinks makes sense, but here's what I'm thinking
on integration:

1) the starting point and integration fork: https://github.com/qwcode/pip
     - default branch is now set to "wheel_install"
     - this is just the install support
     - I just added in that chmod fix from distribute that daniel mentioned.
2) we can make pull requests to it and review, so best if everyone watches
that repo/branch.
3) I turned on the issue support, so we can track issues related to the
effort if we want,
    but the wheel list is probably enough (
https://github.com/qwcode/pip/issues)
4) I'm working on getting travis working for my fork.  if/when that works,
pull request builds will show here:
   https://travis-ci.org/#!/qwcode/pip/pull_requests
5) as for my work on "pip wheel",  my free time this week went to my job
and another pip issue. sunday will have to be when I get started on that.
    I will work in another branch at first, not directly in
"wheel_install", and will submit a pull

Marcus


On Thu, Oct 11, 2012 at 12:15 PM, Paul Moore <p.f.moore@gmail.com> wrote:

> A couple of questions (because I've got myself confused :-))
>
> 1. Where should I go to get the latest version of wheel support for
> pip? Is dholth's fork still the "latest and greatest" at this time?
> 2. Is it worth me waiting for Marcus' branch to land somewhere? Or
> indeed, is it available already?
>
> The reason is that I'd like to look at the code in pip/index.py which
> finds wheels, to add a check that the wheel is valid for the current
> Python API/platform (because it's an issue for me at the moment, so
> I'd like to get it fixed). And I want to make sure I'm working on code
> that's not out of date.
>
> Thanks,
> Paul.
>

Re: [wheel] Latest code for wheel support in pip

From:
Marcus Smith
Date:
2012-10-12 @ 05:56
>
> 4) I'm working on getting travis working for my fork.  if/when that works,
> pull request builds will show here:
>    https://travis-ci.org/#!/qwcode/pip/pull_requests
>

it's working now.  pull away to qwcode/pip:wheel_install and you'll get a
travis build

Re: [wheel] Latest code for wheel support in pip

From:
Paul Moore
Date:
2012-10-12 @ 08:38
On 12 October 2012 06:56, Marcus Smith <qwcode@gmail.com> wrote:
>> 4) I'm working on getting travis working for my fork.  if/when that works,
>> pull request builds will show here:
>>    https://travis-ci.org/#!/qwcode/pip/pull_requests
>
>
> it's working now.  pull away to qwcode/pip:wheel_install and you'll get a
> travis build

OK, just sent a pull request for the platform check code.

Paul.

Re: [wheel] Latest code for wheel support in pip

From:
Daniel Holth
Date:
2012-10-11 @ 19:37
On Thu, Oct 11, 2012 at 3:15 PM, Paul Moore <p.f.moore@gmail.com> wrote:
> A couple of questions (because I've got myself confused :-))
>
> 1. Where should I go to get the latest version of wheel support for
> pip? Is dholth's fork still the "latest and greatest" at this time?
> 2. Is it worth me waiting for Marcus' branch to land somewhere? Or
> indeed, is it available already?
>
> The reason is that I'd like to look at the code in pip/index.py which
> finds wheels, to add a check that the wheel is valid for the current
> Python API/platform (because it's an issue for me at the moment, so
> I'd like to get it fixed). And I want to make sure I'm working on code
> that's not out of date.
>
> Thanks,
> Paul.

I'd start with https://github.com/qwcode/pip/tree/wheel_install.
Unlike my fork, the work has been compressed into just a few commits.

My fork is still where you would go for the builder feature "pip
install --wheel-cache" which IIUC Marcus is refactoring into a "pip
wheel ..." command.

Re: [wheel] Latest code for wheel support in pip

From:
Paul Moore
Date:
2012-10-11 @ 19:44
On 11 October 2012 20:37, Daniel Holth <dholth@gmail.com> wrote:
> On Thu, Oct 11, 2012 at 3:15 PM, Paul Moore <p.f.moore@gmail.com> wrote:
>> A couple of questions (because I've got myself confused :-))
>>
>> 1. Where should I go to get the latest version of wheel support for
>> pip? Is dholth's fork still the "latest and greatest" at this time?
>> 2. Is it worth me waiting for Marcus' branch to land somewhere? Or
>> indeed, is it available already?
>>
>> The reason is that I'd like to look at the code in pip/index.py which
>> finds wheels, to add a check that the wheel is valid for the current
>> Python API/platform (because it's an issue for me at the moment, so
>> I'd like to get it fixed). And I want to make sure I'm working on code
>> that's not out of date.
>
> I'd start with https://github.com/qwcode/pip/tree/wheel_install.
> Unlike my fork, the work has been compressed into just a few commits.

Excellent, thanks.

One further question - the current wheel support patch for pip
deliberately (as far as I am aware) does not depend on the wheel
module itself being installed. In looking at how to add
architecture/abi checking, it's fairly clear to me that it would be
simple to do this using wheel.pep425tags. What's the best way of
avoiding the dependency? Is it reasonable to simply copy the contents
of that file into pip\wheel.py? There's an obvious maintenance issue
then, but I don't really see a way round it...

> My fork is still where you would go for the builder feature "pip
> install --wheel-cache" which IIUC Marcus is refactoring into a "pip
> wheel ..." command.

Yes, I'm looking forward to that as well :-)

Cheers,
Paul.

Re: [wheel] Latest code for wheel support in pip

From:
Daniel Holth
Date:
2012-10-11 @ 19:46
On Thu, Oct 11, 2012 at 3:44 PM, Paul Moore <p.f.moore@gmail.com> wrote:
> On 11 October 2012 20:37, Daniel Holth <dholth@gmail.com> wrote:
>> On Thu, Oct 11, 2012 at 3:15 PM, Paul Moore <p.f.moore@gmail.com> wrote:
>>> A couple of questions (because I've got myself confused :-))
>>>
>>> 1. Where should I go to get the latest version of wheel support for
>>> pip? Is dholth's fork still the "latest and greatest" at this time?
>>> 2. Is it worth me waiting for Marcus' branch to land somewhere? Or
>>> indeed, is it available already?
>>>
>>> The reason is that I'd like to look at the code in pip/index.py which
>>> finds wheels, to add a check that the wheel is valid for the current
>>> Python API/platform (because it's an issue for me at the moment, so
>>> I'd like to get it fixed). And I want to make sure I'm working on code
>>> that's not out of date.
>>
>> I'd start with https://github.com/qwcode/pip/tree/wheel_install.
>> Unlike my fork, the work has been compressed into just a few commits.
>
> Excellent, thanks.
>
> One further question - the current wheel support patch for pip
> deliberately (as far as I am aware) does not depend on the wheel
> module itself being installed. In looking at how to add
> architecture/abi checking, it's fairly clear to me that it would be
> simple to do this using wheel.pep425tags. What's the best way of
> avoiding the dependency? Is it reasonable to simply copy the contents
> of that file into pip\wheel.py? There's an obvious maintenance issue
> then, but I don't really see a way round it...

https://bitbucket.org/dholth/pep425tags

I broke this part out after it became clear that the PEP would not
make sense without a reference implementation. Wheel copies it too.
"Vendorizing".

Daniel

Re: [wheel] Latest code for wheel support in pip

From:
Paul Moore
Date:
2012-10-11 @ 19:49
On 11 October 2012 20:46, Daniel Holth <dholth@gmail.com> wrote:
> https://bitbucket.org/dholth/pep425tags
>
> I broke this part out after it became clear that the PEP would not
> make sense without a reference implementation. Wheel copies it too.
> "Vendorizing".

OK, sounds like copying it to pip/pep425tags.py is the sensible option, then.

I'll do that provisionally, subject to any comments Marcus may have on
how he'd prefer it to be handled from pip's point of view.

Paul.

Re: [wheel] Latest code for wheel support in pip

From:
Marcus Smith
Date:
2012-10-12 @ 04:40
>
> OK, sounds like copying it to pip/pep425tags.py is the sensible option,
> then.
>

sounds good.

Marcus